[macOS 27] Fix missing menu icons. - #122717
Conversation
| if (@available(macOS 27.0, *)) { | ||
| menu_item.preferredImageVisibility = NSMenuItemImageVisibilityVisible; | ||
| } |
There was a problem hiding this comment.
I'm wondering what prevents us to use the else to put the menu_item logic. Is there a macOS version that we still support that doesn't accept the @available format?
I'm trying to check the documentation on @available, but I can't find the specifics.
There was a problem hiding this comment.
avaliable(macOS 27) and code inside will only compile when building with Xcode 27, which is in beta. The other branch will compile with any older SDK we support and use for official builds, but still act the same on macOS 27. So we can only keep it, but I would prefer to keep both, so cleaning up ifdefs will be easier once Xcode 27 is min supported version.
adamscott
left a comment
adamscott
left a comment
There was a problem hiding this comment.
Seems fine to me, other than my question.
3 participants
What problem(s) does this PR solve?
Additional information
Before:
After:
